Choice Function: Replaced sample with choice for selecting a single code#154
Open
Soyvor wants to merge 3 commits intojoeyajames:masterfrom
Open
Choice Function: Replaced sample with choice for selecting a single code#154Soyvor wants to merge 3 commits intojoeyajames:masterfrom
Soyvor wants to merge 3 commits intojoeyajames:masterfrom
Conversation
…andom item from a sequence. This simplifies the code when only one random choice is needed. Pen State Functions: Corrected the function names from pu and pd to penup and pendown, respectively, for clarity and consistency. Position Copy: Used the copy() method to create a copy of the position vector before modifying it. This prevents unintended changes to the original position vector. Distance Calculation: Replaced abs(tt.pos() - start_position) with tt.distance(start_position) to calculate the distance between two points more accurately. Indentation and Formatting: Ensured consistent indentation and formatting throughout the code for readability and maintainability.
…and code readability
Naming Conventions: Renamed private methods to follow Python's naming conventions (snake_case). Returning None: Changed the return value of peek and pop methods to None instead of False for clarity. In Python, None is typically used to indicate the absence of a value. Use of Dummy Element: Initialized the heap with a dummy element at index 0 to simplify index calculations. This helps in avoiding special cases in the code. Output Formatting: Changed the output printing to exclude the dummy element when printing the heap elements.
Soyvor
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…andom item from a sequence. This simplifies the code when only one random choice is needed.
Pen State Functions: Corrected the function names from pu and pd to penup and pendown, respectively, for clarity and consistency.
Position Copy: Used the copy() method to create a copy of the position vector before modifying it. This prevents unintended changes to the original position vector.
Distance Calculation: Replaced abs(tt.pos() - start_position) with tt.distance(start_position) to calculate the distance between two points more accurately.
Indentation and Formatting: Ensured consistent indentation and formatting throughout the code for readability and maintainability.