Skip to content

fix: ensure package name is encoded#1554

Open
paustint wants to merge 1 commit intomainfrom
bug/1553
Open

fix: ensure package name is encoded#1554
paustint wants to merge 1 commit intomainfrom
bug/1553

Conversation

@paustint
Copy link
Contributor

Ensure that an outbound package name is encoded properly to avoid "No package.xml found"

Ensure that an outbound package name is encoded properly to avoid "No package.xml found"
Copilot AI review requested due to automatic review settings February 19, 2026 23:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses failures when deploying metadata into an existing outbound Change Set by ensuring the outbound package/change set name is URI-encoded before being used downstream (preventing Salesforce-side “No package.xml found” scenarios when the name contains special characters).

Changes:

  • Rename the onDeploy callback’s first parameter for clarity (changesetPackagepackageName).
  • Encode the selected packageName via encodeURIComponent before passing it into the deploy flow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
libs/features/deploy/src/add-to-changeset/AddToChangesetConfigModal.tsx Clarifies the deploy callback parameter name to better reflect what’s passed.
libs/features/deploy/src/add-to-changeset/AddToChangeset.tsx Encodes the outbound package/change set name before triggering the deploy workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments