Conversation
Ensure that an outbound package name is encoded properly to avoid "No package.xml found"
There was a problem hiding this comment.
Pull request overview
This PR addresses failures when deploying metadata into an existing outbound Change Set by ensuring the outbound package/change set name is URI-encoded before being used downstream (preventing Salesforce-side “No package.xml found” scenarios when the name contains special characters).
Changes:
- Rename the
onDeploycallback’s first parameter for clarity (changesetPackage→packageName). - Encode the selected
packageNameviaencodeURIComponentbefore passing it into the deploy flow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libs/features/deploy/src/add-to-changeset/AddToChangesetConfigModal.tsx | Clarifies the deploy callback parameter name to better reflect what’s passed. |
| libs/features/deploy/src/add-to-changeset/AddToChangeset.tsx | Encodes the outbound package/change set name before triggering the deploy workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that an outbound package name is encoded properly to avoid "No package.xml found"