Fix copyfile fallback when server-side SMB copy is unsupported#337
Open
K3N44N wants to merge 1 commit intojborean93:masterfrom
Open
Fix copyfile fallback when server-side SMB copy is unsupported#337K3N44N wants to merge 1 commit intojborean93:masterfrom
K3N44N wants to merge 1 commit intojborean93:masterfrom
Conversation
…supported Catch SMBOSError with STATUS_NOT_SUPPORTED from smbclient_copyfile and fallback to copyfileobj so copyfile() still succeeds on servers that do not support server-side SMB copy. Add test covering the fallback behavior. Fixes jborean93#232
Owner
|
Thanks for the PR, looks like there's just some formatting changes that need to be made but overall the changes and tests look great. You can auto format the code with python -m pip install -r requirements-dev.txt
python -m black .
python -m isort . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
smbclient.shutil: fallback to client-side copy if server-side copy unsupported
Catch SMBOSError with STATUS_NOT_SUPPORTED from smbclient_copyfile and fallback to copyfileobj so copyfile() still succeeds on servers that do not support server-side SMB copy.
Add test covering the fallback behavior.
Fixes #232
This is my first time contributing here, please let me know if I missed anything or my PR requires any changes.