Adding support for vim compiled with python3 support#42
Open
juanwolf wants to merge 1 commit intojaxbot:masterfrom
juanwolf:master
Open
Adding support for vim compiled with python3 support#42juanwolf wants to merge 1 commit intojaxbot:masterfrom juanwolf:master
juanwolf wants to merge 1 commit intojaxbot:masterfrom
juanwolf:master
Conversation
Owner
|
This would break it for anyone who has only python and not python3, though. Ultimately it probably needs a wrapper, like this: https://github.com/jaxbot/github-issues.vim/pull/57/files As for the first PR, congratulations! And yes, it is fine to have both a PR and an issue, though the issue would typically be phrased as a bug statement ("Does not work with only python3") instead of a fix title. But works either way, I'm not picky :p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Great work for this project !
Except that was not working for me because I'm using vim compiled with python3 support not python so the autoload/browserlink.vim script was giving me some errors.
I replaced few elements to make it work but it would be nice if there's a way to manage both.
I did a pull request to show you what I've changed to make it work, if it can help.
Sorry first pull request of my life, so I opened an issue AND a pull request 👎