Open
Conversation
RElated to issue ivoa-std#4 this Commit introduces a couple of subsections for new rebinning / reprojecting parameters in SODA
pdowler
reviewed
Nov 27, 2023
Collaborator
pdowler
left a comment
pdowler
left a comment
There was a problem hiding this comment.
Some organisational suggestions:
- change DOCTYPE back to WD in the Makefile
- re-order the filtering param sections so that MOC comes after POLYGON and PIXELS comes at the end
- isn't DPTYPE a kind of transformation (in the general sense)? Move it to the "Transform" section?
I will comment on individual items separately.
adding sub-sampling by picking up "1 upon n" pixels in the area of interest
moving DPTYPE subsection to Transform and reorder the filtering section according to Pat's comments
Collaborator
Author
Changes made |
Working draft 1.1 first version
clarifying behavior for DPTYPE parameter
- PIXELS and parameter multiplicity - RESPONSEFORMAT = application/hips specificities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add transform parameters, pixel ranges, Dataset format changes, product type reduction