fix: return error when OAuth token response is missing access_token#5
Merged
privateip merged 1 commit intoitential:mainfrom Mar 9, 2026
Merged
Conversation
When the OAuth token endpoint returns HTTP 200 but the response body
either fails to decode or omits the access_token field, the client was
silently marking itself authenticated with an empty token. Subsequent
requests were sent without a Bearer header, with no error surfaced to
the caller.
- [x] Bug fix
- `authenticatePlatform`: return a descriptive error if JSON decoding
fails ("decode OAuth token response: <err>") or if access_token is
absent or empty ("OAuth token response missing access_token field")
- `TestOAuthMissingTokenReturnsError`: replaces the old test that
asserted missing token was silently ignored; now asserts an error
containing "access_token" is returned
- `TestOAuthInvalidJSONReturnsError`: replaces the old test that
asserted malformed JSON still succeeded; now asserts an error is
returned
go test ./... — all 40 tests pass
CGO_ENABLED=1 go test -race ./... — no races detected
- [x] Code follows the project's style guidelines
- [x] Self-review of code has been performed
- [x] Code has been commented where necessary
- [x] Commits follow conventional format (`type: subject`)
- [x] No secrets or credentials committed
- [x] Documentation has been updated accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the OAuth token endpoint returns HTTP 200 but the response body either fails to decode or omits the access_token field, the client was silently marking itself authenticated with an empty token. Subsequent requests were sent without a Bearer header, with no error surfaced to the caller.
Type of Change
Changes Made
authenticatePlatform: return a descriptive error if JSON decoding fails ("decode OAuth token response: ") or if access_token is absent or empty ("OAuth token response missing access_token field")TestOAuthMissingTokenReturnsError: replaces the old test that asserted missing token was silently ignored; now asserts an error containing "access_token" is returnedTestOAuthInvalidJSONReturnsError: replaces the old test that asserted malformed JSON still succeeded; now asserts an error is returnedTesting
go test ./... — all 40 tests pass
CGO_ENABLED=1 go test -race ./... — no races detected
Checklist
type: subject)