Updates MJCF Importer to Isaac Sim MJCF Importer 3.0#4687
Open
kellyguo11 wants to merge 1 commit intoisaac-sim:developfrom
Open
Updates MJCF Importer to Isaac Sim MJCF Importer 3.0#4687kellyguo11 wants to merge 1 commit intoisaac-sim:developfrom
kellyguo11 wants to merge 1 commit intoisaac-sim:developfrom
Conversation
Contributor
Greptile SummaryThis PR updates the MJCF converter to use Isaac Sim 5.0's new Major Changes:
Documentation:
Key Implementation Details:
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[MjcfConverter.__init__] -->|Pre-adjust usd_file_name| B[robot/robot.usda]
B --> C[AssetConverterBase.__init__]
C -->|Check if conversion needed| D{USD exists & hash matches?}
D -->|No| E[_convert_asset]
D -->|Yes| F[Skip conversion]
E -->|Clean existing subdir| G[shutil.rmtree output_subdir]
G --> H[Create MJCFImporterConfig]
H -->|Parameters| I[mjcf_path, usd_path, merge_mesh,<br/>collision_from_visuals, collision_type,<br/>allow_self_collision]
I --> J[MJCFImporter.import_mjcf]
J --> K[Output: usd_dir/robot_name/robot_name.usda]
style A fill:#e1f5ff
style E fill:#fff4e1
style J fill:#e7f9e7
style K fill:#e7f9e7
Last reviewed commit: 30d6c57 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Isaac Sim recently updated the MJCF importer to use https://github.com/newton-physics/mujoco-usd-converter, which resulted in major changes to APIs and functionality.
To accommodate for these changes, the IsaacLab wrapper for the MJCF importer also requires breaking changes to the configuration and parameters.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there