fix: correct misleading comments and docs in BinaryJointAction

[alltheseas]

Summary

Fix misleading inline comments and an imprecise docstring in BinaryJointAction.process_actions.

• The inline comments stated # true: close, false: open, which describes the binary_mask variable but reads as describing the action convention — the opposite of actual behavior
• The class docstring said "positive values" for float open actions, but the implementation uses < 0, so zero maps to open. Updated to "non-negative values"

No behavior change. Comments and docs now match the code.

Fixes #4670

Changes

• source/isaaclab/isaaclab/envs/mdp/actions/binary_joint_actions.py
  • Class docstring: "positive" → "non-negative" for float open actions
  • Inline comments: clarify action-to-command mapping unambiguously

Signed-off-by: alltheseas alltheseas@users.noreply.github.com

[greptile-apps]

Greptile Summary

This PR fixes misleading documentation in two areas:

1. BinaryJointAction: Updated class docstring from "positive values" to "non-negative values" for float open actions, matching the actual implementation (action >= 0 maps to open). Clarified inline comments to describe action-to-command mapping from the user's perspective rather than the internal binary_mask variable.

2. resolve_matching_names: Fixed inverted docstring that incorrectly described the preserve_order parameter behavior - the documentation now correctly states that preserve_order=False (default) follows list order, while preserve_order=True follows regex key order.

Both changes are documentation-only with no behavioral impact. The code logic remains unchanged and functions correctly.

Confidence Score: 5/5

• This PR is completely safe to merge with zero risk
• Documentation-only changes with no code behavior modifications - the updates correct misleading comments and docstrings to accurately match existing implementation logic
• No files require special attention

Important Files Changed

Filename	Overview
source/isaaclab/isaaclab/envs/mdp/actions/binary_joint_actions.py	Corrected misleading docstring and inline comments to accurately describe action-to-command mapping behavior
source/isaaclab/isaaclab/utils/string.py	Fixed inverted docstring describing preserve_order parameter behavior with clearer examples

_{Last reviewed commit: 3e0f702}

[greptile-apps]

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}