Adds new depth AOV to camera classes#4662
Conversation
Greptile SummaryAdds support for a new Key Changes:
Issues Found:
Confidence Score: 3/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Camera Configuration] -->|data_types includes depth_new| B{Camera Type?}
B -->|Camera| C[Register Depth AOV Annotator]
B -->|TiledCamera| D[Register Depth AOV Annotator]
C --> E[Create Annotator: Depth]
D --> F[Create Annotator: Depth]
E --> G[Attach to Render Product]
F --> H[Attach to Render Products]
G --> I[Update Buffers]
H --> J[Update Buffers]
I --> K[Clip values > max to inf]
J --> L{Apply Clipping?}
L -->|distance_to_camera| M[Clip to inf]
L -->|depth_new| N[Missing Clip Step]
K --> O[Apply depth_clipping_behavior]
M --> O
N --> O
O -->|none| P[Keep inf values]
O -->|zero| Q[Replace inf with 0.0]
O -->|clamp| R[Replace inf with max]
P --> S[Output depth_new data]
Q --> S
R --> S
Last reviewed commit: 5d3575c |
| if name == "depth_new": | ||
| rep.AnnotatorRegistry.register_annotator_from_aov( | ||
| aov="Depth", output_data_type=np.float32, output_channels=1 | ||
| ) |
There was a problem hiding this comment.
annotator registration called inside nested loop (line 428: for cam_prim, line 459: for name) - if multiple cameras use depth_new, this registers the same annotator multiple times - wrap in a check or move outside loop
# Before the outer loop (around line 427), add:
_registered_aovs = set()
# Then in the inner loop:
if name == "depth_new" and "Depth" not in _registered_aovs:
rep.AnnotatorRegistry.register_annotator_from_aov(
aov="Depth", output_data_type=np.float32, output_channels=1
)
_registered_aovs.add("Depth")
Additional Comments (1)
|
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there