Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
without<IDs...>[p]directive. It is the counterpart towith<ID>(ref)[p]andwith_local<T, ID>[p].withoutstrips out any contexts that match the IDs specified in the argument.It is extremely useful for stripping unnecessary contexts from a parser type that is intended to be instantiated in a distinct translation unit. Without
without, users must specify all the extraneous contexts specified by the full parser definition becauseIRIS_X4_INSTANTIATErequires the concrete context type. Withwithout, users can shave off all the irrelevant contexts to minify the variations of the instantiated parser type.Such operation is crucial for real-world grammars and it can often reduce the compile times proportionally.