Make header generation rename the file after format#28
Merged
Conversation
Member
|
I think the real problem is that alloy build is mistakenly enabled in X4 modification; it should only build X4 on such cases. So the fix for the root issue would need modification to I'm not sure why the "permission denied" error is not occurring in local build (where it builds both X4 and alloy by default) but I think the above fix would eliminate the error on CI. |
yaito3014
force-pushed
the
preprocess-rename-after-format
branch
from
f3cef5f to
b419bda
Compare
…ess-rename-after-format
Member
Author
|
I completely forgot to add |
Member
oh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, some Windows workflows fail due to permission problem with
tuple_impl.hpp.This PR attempts to fix the issue by not creating and formatting the file but formatting and renaming the file.