Skip to content

[FusilliPlugin] rm -rf#247

Merged
AaronStGeorge merged 3 commits intoiree-org:mainfrom
AaronStGeorge:p036-move-fusilli-plugin-to-rocm-libs
Mar 13, 2026
Merged

[FusilliPlugin] rm -rf#247
AaronStGeorge merged 3 commits intoiree-org:mainfrom
AaronStGeorge:p036-move-fusilli-plugin-to-rocm-libs

Conversation

@AaronStGeorge
Copy link
Contributor

@AaronStGeorge AaronStGeorge commented Mar 13, 2026

The fusilli hipDNN plugin has been moved to rocm-libraries/dnn-providers/fusilli-provider.

@AaronStGeorge @claude
Remove hipdnn-plugin (moved to rocm-libraries)
7155b78 
The fusilli hipDNN plugin has been moved to
rocm-libraries/dnn-providers/fusilli-provider/.
TheRock's iree-libs/CMakeLists.txt already points
to the new location.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
IanWood1
IanWood1 reviewed Mar 13, 2026
View reviewed changes
Copy link
Contributor

@IanWood1 IanWood1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it already documented in this repo that the plugin lives in ROCm/rocm-libraries? I couldn't find anything with a quick scan of the README.

@sjain-stanford
Copy link
Member

sjain-stanford commented Mar 13, 2026

Like Ian said, let's add a note to the README about the plugin location (here or in a follow-on).

@rsuderman
Copy link
Contributor

rsuderman commented Mar 13, 2026

Remember to remove ThePebble.py as well. If we are removing the plugin and CI for it there is no reason to keep that script around.

@sjain-stanford
Copy link
Member

sjain-stanford commented Mar 13, 2026

Remember to remove ThePebble.py as well. If we are removing the plugin and CI for it there is no reason to keep that script around.

Strange, for some reason this rm -rf didn't remove ThePebble.py.

@AaronStGeorge
Not removed?
8cf4145 
I didn't `rm -rf` manually I asked claude to do it... And it did it wrong? Odd.
@AaronStGeorge
Update README.md
1e13553
@AaronStGeorge
Copy link
Contributor Author

AaronStGeorge commented Mar 13, 2026

Remember to remove ThePebble.py as well. If we are removing the plugin and CI for it there is no reason to keep that script around.

Strange, for some reason this rm -rf didn't remove ThePebble.py.

This was Claude... not something I would have expected it to mess up TBH.

@AaronStGeorge AaronStGeorge enabled auto-merge (squash) March 13, 2026 21:24
@AaronStGeorge AaronStGeorge merged commit dd277dd into iree-org:main Mar 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IanWood1 IanWood1 IanWood1 left review comments

@sjain-stanford sjain-stanford sjain-stanford approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AaronStGeorge @sjain-stanford @rsuderman @IanWood1