Simplify string formatting in PostgreSQL auth configuration#97
Merged
Simplify string formatting in PostgreSQL auth configuration#97
Conversation
The test was checking for TaskCompleted scheduler events immediately after task.wait() returned. There is a small window between when the worker commits the task's "complete" state to the database (which causes task.wait() to return) and when it calls scheduler.notify(TaskCompleted). On a multi-threaded runtime the test can read the scheduler events before the worker records the event. Fix by polling for the TaskCompleted event with a timeout instead of checking it once. https://claude.ai/code/session_017uGnkXcc2zLYNX3sdipDJs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the string formatting in the PostgreSQL
pg_hba.confconfiguration setup to use a more idiomatic Rust approach.Key Changes
format!()macro with a string literal to a raw string literal with.to_string()method callImplementation Details
The change replaces the
format!("\...")pattern with a raw string literal"\..."followed by.to_string(). Both approaches produce the same result, but the latter is more direct and avoids the overhead of theformat!()macro when no interpolation is needed. This is a minor code style improvement that makes the intent clearer—we're simply converting a static string to an ownedStringrather than formatting one.https://claude.ai/code/session_017uGnkXcc2zLYNX3sdipDJs