fix(app-launcher): improvements on canOpenUrl and openUrl #2476
+63
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
ItsChaceD,
OS-pedrogustavobilro,
OS-ruimoreiramendes,
alexgerardojacinto,
andredestro,
eric-horodyski,
markemer and
theproducer
|
Released dev build of app with dev version: 8.0.1-dev-2476-20260205T160422.0 |
Contributor
|
@jcesarmobile still reviewing and testing the PR but just wanted to confirm, shouldn't the PR title for this monorepo reference the specific plugin, i.e. something like |
app-launcher/android/src/main/java/com/capacitorjs/plugins/applauncher/AppLauncherPlugin.java
Outdated
Show resolved
Hide resolved
app-launcher/android/src/main/java/com/capacitorjs/plugins/applauncher/AppLauncherPlugin.java
Outdated
Show resolved
Hide resolved
app-launcher/android/src/main/java/com/capacitorjs/plugins/applauncher/AppLauncherPlugin.java
Outdated
Show resolved
Hide resolved
jcesarmobile
changed the title
OS-pedrogustavobilro
approved these changes
Feb 9, 2026
alexgerardojacinto
approved these changes
Feb 10, 2026
jcesarmobile
added a commit
that referenced
this pull request
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canOpenUrl now correctly checks if an app scheme can be opened on Android
fixes #1744, which is closed as it was considered a docs issue, but I think it was a real issue since it's possible to detect if an app scheme can be opened, so I added code to detect them instead.
Also
openUrlwas not working for some internal settings urls for Android, so I also fixed itcloses #1620
And added some extra docs, improved the
openUrlexample code and added an example about how to add an app scheme to thequeries.