fix(android): fix incorrect layout sizing when launching with keyboard open#53
Open
Aiden10x wants to merge 1 commit intoionic-team:mainfrom
Open
fix(android): fix incorrect layout sizing when launching with keyboard open#53Aiden10x wants to merge 1 commit intoionic-team:mainfrom
Aiden10x wants to merge 1 commit intoionic-team:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed the condition inside Keyboard.java setOnApplyWindowInsetsListener to call possiblyResizeChildOfContent(showingKeyboard) whenever resizeOnFullScreen is true, rather than only when the keyboard is actively showing.
Change Type
Rationale / Problems Fixed
When an app is launched while the software keyboard is open (for example, when opening the app from the device's launcher search bar), the system briefly reports the keyboard as open, and then immediately dismisses it as the app takes focus.
Previously, the setOnApplyWindowInsetsListener conditionally fired possiblyResizeChildOfContent(true) only if the keyboard was showing. When the keyboard immediately closed, the listener fired again but completely ignored the false state, leaving the app's UI permanently shrunk/pushed up.
Tests or Reproductions
Before: The app loads, the keyboard hides, but the bottom portion of the screen remains pushed up
After: The app loads, the keyboard hides, and the layout correctly re-expands to claim the full screen height
Platforms Affected