Fix complete_sales_order_shipment task#11525
Open
SchrodingersGat wants to merge 6 commits intoinventree:masterfrom
Open
Fix complete_sales_order_shipment task#11525SchrodingersGat wants to merge 6 commits intoinventree:masterfrom
SchrodingersGat wants to merge 6 commits intoinventree:masterfrom
Conversation
- Perform allocation *before* marking shipment as complete - Ensure task is not marked as complete before it is actually done
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
SchrodingersGat
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11525 +/- ##
=======================================
Coverage 88.08% 88.09%
=======================================
Files 1296 1296
Lines 59182 59179 -3
Branches 1934 1934
=======================================
- Hits 52133 52131 -2
+ Misses 6569 6568 -1
Partials 480 480
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This was referenced Mar 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses a shortfall of the existing Sales order shipment completion process. Specifically, the shipment is first marked as complete, and then the allocated items are processed (by the background worker). If the background process fails (as addressed in #11500) then the allocated items sit in "limbo" - the shipment has been marked as complete, and cannot be completed again - but the item allocations are not completed correctly.
Solution
Complete the items first, and then mark the shipment as shipped. This offloads the entire process to the background worker thread, and only marks the shipment as complete after all the tasks are actually done.
TODO
References