Open
Conversation
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sander2
reviewed
Jun 15, 2022
| # use those to create a new transaction | ||
| rawtx=$(bitcoin-cli createrawtransaction $rawinputs $rawoutputs) | ||
| # fund that tx with a better fee rate | ||
| fundedtx=$(bitcoin-cli fundrawtransaction $rawtx "{\"changeAddress\": \"$CHANGE_ADDRESS\", \"feeRate\": $FEE_RATE}" | jq -r .hex) |
Member
There was a problem hiding this comment.
You are counting on all addresses in the wallet to have been registered to the parachain, which is most cases will be true, but it's still a risky assumption. If e.g. a non-empty wallet was used when first starting the vault this would not hold (we do tell vaults not to do this.. but still)
Member
Author
There was a problem hiding this comment.
Theft reporting was removed here, addresses are no longer required to be registered.
Member
|
@gregdhill could you address the comments so we can merge this please? |
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill gregorydhill@outlook.com
Until we have programmatic support (and even after) we should have some documentation for Replace-By-Fee (RBF) to demonstrate how Vaults may increase fees to prevent liquidation after significant Bitcoin mempool congestion.
See also: https://github.com/BlockchainCommons/Learning-Bitcoin-from-the-Command-Line/blob/master/05_2_Resending_a_Transaction_with_RBF.md
UPDATE: automatic RBF functionality was implemented here