Fix OpenAPI schema cache collision by including schema_path in cache key#466
Merged
Fix OpenAPI schema cache collision by including schema_path in cache key#466
Conversation
This PR fixes a cache key issue in schema loading that could cause incorrect cache reuse for OpenAPI 3 schemas. - file content hash - parser options hash For OpenAPI 3, relative `$ref` resolution depends on `schema_path`, so two files with identical root content but different directories could incorrectly share the same cached schema object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a cache key issue in schema loading that could cause incorrect cache reuse for OpenAPI 3 schemas.
For OpenAPI 3, relative
$refresolution depends onschema_path, so two files with identical root content but different directories could incorrectly share the same cached schema object.