Fix warnings, NULL is meant for pointers only.#18
Open
JoakimSoderberg wants to merge 1 commit intointeractive-matter:masterfrom
Open
Fix warnings, NULL is meant for pointers only.#18JoakimSoderberg wants to merge 1 commit intointeractive-matter:masterfrom
JoakimSoderberg wants to merge 1 commit intointeractive-matter:masterfrom
Conversation
Also usually NULL is defined as 0, so using that as an error case when 0 is also returned as success does not make much sense. However, the return value for skipHeader is never checked anywhere.... so this is just to shut up the compiler mostly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I got some of these warnings when compiling:
Since
int HTTPClient::skipHeader(FILE* stream)returns anint...Also usually NULL is defined as 0, so using that as an error case when 0 is also returned as success does not make much sense.
However, the return value for skipHeader is never checked anywhere.... so this is just to shut up the compiler mostly.