Properly get frequency in kernel 6.15 and up#425
Open
tewaro wants to merge 1 commit intointel:masterfrom
Open
Conversation
tewaro
force-pushed
the
fix-media-pad-from-6.15-update
branch
from
af7cdc8 to
0ad3012
Compare
From kernel 6.15+, `v4l2_get_link_freq()` supports a pad-based lookup via `struct media_pad *`. The in-kernel IVSC CSI driver also dropped its `V4L2_CID_LINK_FREQ` control in 6.15, so the old ctrl_handler path returns `-ENOENT`. Use the pad instead. Signed-off-by: Aditya Tewari <adityaatewari@gmail.com>
tewaro
force-pushed
the
fix-media-pad-from-6.15-update
branch
from
0ad3012 to
ee8f7f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From kernel 6.15+,
v4l2_get_link_freq()supports a pad-based lookup viastruct media_pad *. The in-kernel MEI CSI driver also dropped itsV4L2_CID_LINK_FREQcontrol in 6.15, so the old ctrl_handler path returns-ENOENT.Use the pad instead.
This might help with #423, although not sure if it's a universal fix.
In journalctl I was seeing:
The change in MEI CSI driver is in this commit:
torvalds/linux@56f697e on line 572.
Applying this patch and recompiling the driver fixed it for me.
Would really like this patch in upstream, happy to help any way I can.
Tested on 6.8, 6.14, and 6.17.