Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

avoid netcat dependency#225

Merged
pohly merged 2 commits intointel:masterfrom
pohly:socat-ostree
Jul 11, 2017
Merged

avoid netcat dependency#225
pohly merged 2 commits intointel:masterfrom
pohly:socat-ostree

Conversation

@pohly
Copy link
Contributor

@pohly pohly commented Jul 3, 2017

Usage of the host netcat can be replaced by building socat-native.
Should fix PR #221.

pohly added 2 commits July 7, 2017 08:09
@pohly
refkit_ostree.py: avoid dependency on host netcat
b179518 
netcat is not installed by default in minimal containers (original
OpenSUSE, crops). We can avoid depending on additional host tools
by building socat-native from OE-core.

While at it, replace multiple calls to get_bitbake_var with a single
get_bitbake_vars(), which is faster because each call is one call of
"bitbake -e".

Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
@pohly
Revert "docker: install netcat in OpenSUSE container"
9e2dc87 
This reverts commit c8f3e64.

Usage of the host netcat was replaced by building socat-native.

Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
@intel intel deleted a comment from mythi Jul 7, 2017
@pohly
Copy link
Contributor Author

pohly commented Jul 10, 2017

test this please

Failed in https://ostroproject.org/jenkins/job/intel-iot-refkit_pull-requests/2196/console with:

2:58:05.871 | /bin/sh: session-helper/org.freedesktop.Flatpak.service: No such file or directory
02:58:05.871 | Makefile:5248: recipe for target 'session-helper/org.freedesktop.Flatpak.service' failed
02:58:05.871 | make[2]: *** [session-helper/org.freedesktop.Flatpak.service] Error 1
02:58:05.871 | make[2]: *** Waiting for unfinished jobs....
02:58:05.871 | make[2]: Leaving directory '/srv/jenkins/workspace/ci-2017-07-07_04-27-23-build-2196/build/refkit-poky/tmp/work/x86_64-linux/flatpak-native/0.9.3+gitAUTOINC+1a49029f9d-r0/build'
02:58:05.871 | Makefile:4420: recipe for target 'all-recursive' failed
02:58:05.871 | make[1]: *** [all-recursive] Error 1
02:58:05.871 | make[1]: Leaving directory '/srv/jenkins/workspace/ci-2017-07-07_04-27-23-build-2196/build/refkit-poky/tmp/work/x86_64-linux/flatpak-native/0.9.3+gitAUTOINC+1a49029f9d-r0/build'
02:58:05.871 | Makefile:1676: recipe for target 'all' failed
02:58:05.871 | make: *** [all] Error 2
02:58:05.871 | WARNING: /srv/jenkins/workspace/ci-2017-07-07_04-27-23-build-2196/build/refkit-poky/tmp/work/x86_64-linux/flatpak-native/0.9.3+gitAUTOINC+1a49029f9d-r0/temp/run.do_compile.174727:1 exit 1 from 'exit 1'
02:58:05.871 | ERROR: Function failed: do_compile (log file is located at /srv/jenkins/workspace/ci-2017-07-07_04-27-23-build-2196/build/refkit-poky/tmp/work/x86_64-linux/flatpak-native/0.9.3+gitAUTOINC+1a49029f9d-r0/temp/log.do_compile.174727)

@pohly
Copy link
Contributor Author

pohly commented Jul 10, 2017

test this please

@pohly pohly requested a review from okartau July 10, 2017 11:22
@pohly
Copy link
Contributor Author

pohly commented Jul 10, 2017

Now it has worked - @okartau, okay to merge?

@okartau
Copy link
Contributor

okartau commented Jul 10, 2017

yes looks good!

pohly added a commit to pohly/intel-iot-refkit that referenced this pull request Jul 10, 2017
@pohly
refkit: Merge multiple PRs in one
e03140d 
This merges PR intel#225, PR intel#230, PR intel#234, PR intel#237.

Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
@pohly pohly merged commit 9e2dc87 into intel:master Jul 11, 2017
@pohly pohly mentioned this pull request Jul 12, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@okartau okartau Awaiting requested review from okartau

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pohly @okartau

Comments