Open
Conversation
|
balzss
commented
Jan 13, 2026
balzss
force-pushed
the
button-rework-v12
branch
4 times, most recently
from
56040c0 to
a63629b
Compare
balzss
force-pushed
the
button-rework-v12
branch
from
a63629b to
4f6a2ed
Compare
Reworked Button, CondensedButton, and IconButton theming: - Removed individual component theme.ts files in favor of centralized BaseButton styles - Updated icon sizing inside buttons - Fixed button active state - Added condensed size and disabled variant styling - Set AI button to use transparent background - Migrated button wrapper components to new theme structure
balzss
force-pushed
the
button-rework-v12
branch
from
4f6a2ed to
3360f15
Compare
balzss
changed the title
matyasf
requested changes
Feb 17, 2026
Collaborator
matyasf
left a comment
matyasf
left a comment
There was a problem hiding this comment.
See my comments.
Also there might be something off with the primary-inverse button's text color in the dark theme:
Similar issue with the inverse ToggleButton:
- You can delete
BaseButton/theme.ts - What about
CloseButton? Will it be converted later? - Please use the new icons in the examples (the README files)
- Please use the new icons in the regression test
matyasf
requested changes
Feb 20, 2026
Collaborator
matyasf
left a comment
matyasf
left a comment
There was a problem hiding this comment.
- The last CloseButton example still uses a old icon
- The samples I linked above still look bad ... what about using a
Viewwith e.g.warningbackground, these color variants are intended for such use case, right? - Please put changes in the upgrade guide (the new sizes and the theme token changes)
Comment on lines
+47
to
+49
| 'x-small': sharedTokens.legacy.spacing.xSmall, | ||
| small: sharedTokens.legacy.spacing.small, | ||
| medium: sharedTokens.legacy.spacing.medium |
Collaborator
There was a problem hiding this comment.
I could not find these in the token changelog. Is it OK, that we use here legacy tokens? Perhaps leave here a comment about why
| ...props | ||
| } = this.props | ||
|
|
||
| const themeOverride = this.props.themeOverride |
Collaborator
There was a problem hiding this comment.
Why is this needed here? why is it not needed for others like IconButton?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4787
Summary
Migrates Button, CondensedButton, and IconButton to the new v12 centralized theme system.
theme.tsfiles from Button, CondensedButton, and IconButton (they re-exported BaseButton's theme) — theming is now handled centrally viawithStyle(null, 'BaseButton')withStyleReworktowithStyleand from legacygenerateComponentThemeto the new token-based approach (NewComponentTypes/SharedTokens)opacity: 0.5)condensedSmallandcondensedMediumrenderIconWithPropswith proper size mapping per button size::beforepseudo-element mask technique instead of relying on background gradient as borderdisplay: blocktodisplay: flexwithalignItems: centerfor proper vertical alignmentdarken/lightencolor utils with dedicated theme tokens for hover/active statesTest plan
condensedSmall,condensedMedium) render at the correct compact heights