fix: sanitize TX_POOL_URL to ensure trailing slash#223
Closed
init4samwise wants to merge 1 commit intomainfrom
Closed
fix: sanitize TX_POOL_URL to ensure trailing slash#223init4samwise wants to merge 1 commit intomainfrom
init4samwise wants to merge 1 commit intomainfrom
Conversation
init4samwise
requested review from
Evalir,
dylanlott and
prestwich
as code owners
Member
|
@init4samwise CI is broken |
Contributor
Author
|
Closing in favor of #224 which supersedes this with the same fix plus test corrections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the issue where
TX_POOL_URLconfiguration required a trailing slash for correct behavior withUrl::join(). Previously, this was documented in the README but not enforced in code.Changes
src/lib.rs: Addedensure_trailing_slash()function that sanitizes the URL when config is loadedREADME.md: Removed the "(must end with/)" requirement from the docs since it's now handled automaticallyWhy this matters
The
url::Url::join()function behaves differently based on whether the base URL ends with a slash:http://example.com/api.join("transactions") →http://example.com/transactions(replaces path segment)http://example.com/api/.join("transactions") →http://example.com/api/transactions(appends)By sanitizing the URL at config load time, we prevent this subtle bug from affecting users who forget the trailing slash.
Closes ENG-1531