transpile: Use enum for current_block labels#1557
transpile: Use enum for current_block labels#1557Rua wants to merge 1 commit intoimmunant:masterfrom
current_block labels#1557Conversation
|
I notice that this is failing because transpiled code is referencing enum variants that do not exist. The code currently relies on |
|
I'm not sure how much we'll need this once the relooper changes land; @randomPoison thoughts? |
|
@ahomescu This still very much necessary! I specifically split out #1523 as work to do post-refactoring. But we will want to wait to land this until after #1558 lands. @Rua the issue you point out in your comment will be easier to address after #1558. In the reworked relooper algorithm we now have a pass that walks the structured CFG and gathers the set of all entries that need |
randomPoison
left a comment
There was a problem hiding this comment.
This looks good to me, thank you for putting this together 💜 After looking over the code it's not clear to me why the test is failing, the way you are gathering the set of labels seems correct. But I'm not going to dig into this now because #1558 is going to rework the relevant code anyway. Please wait until that PR lands and then rebase your changes. If things are still broken after that point I can help debug the issue 😸
The enum variants now suffice for debugging purposes, so I've removed the
debug_labelscommand line option.