Open
Conversation
telecos
force-pushed
the
feature/support-v4-color
branch
from
f0e8931 to
b38ec3a
Compare
telecos
force-pushed
the
feature/support-v4-color
branch
from
cf426f9 to
7f32d21
Compare
telecos
changed the title
telecos
force-pushed
the
feature/support-v4-color
branch
from
f4350df to
4ec15b3
Compare
197g
reviewed
Mar 4, 2026
Member
There was a problem hiding this comment.
LGTM, looks to me like the ICC approach is tenable.
@fintelia Still I don't want to decide this alone since it'll be a template for other formats. The advantage here is that we don't invent our own representation; the disadvantage that if ICC proves too rigid for some representations we may have to diverge in some decoder and that certainly creates complexity. Also in case we need access to concrete data after all (i.e the ICC file fails to represent important information that later turns out is important) then we will end up with more code than having one solution with all the maintenance overhead.
So, preliminary approval from my side pending other directional input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is extending the BMP decoder to parse color space information from
BITMAPV4HEADERandBITMAPV5HEADERstructures. Previously, only thePROFILE_EMBEDDEDICC path in V5 headers was handled; this PR adds support for thebV4CSType/bV5CSTypefield and its associated data across all V4/V5 color space types.The parsed parameters are used to create an equivalent ICC profile which can be exposed through existing icc_profile() method, removing thus the need to expose the bmp-specific V4/V5 parameters.
This work is covering discrepancy number 8 from #2747