Open
Conversation
Sets up a migrator object suitable for testing, it's quiet.
Owner
|
Good idea. However, what about the people who don't use rspec? Maybe there should be an env var or something that is set if you want to generate spec file? I there there is something in Rails itself about this, but don't remember exactly how it works there |
Author
|
|
Owner
|
Cool. That's a great idea
…
On Dec 15, 2020 at 1:44 PM, <Michael G. Schwern ***@***.***)> wrote:
Rails.configuration.generators.options[:rails] can be introspected to get the test_framework. I'll see about putting something together for minitest.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub (#162 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AACE7EVUHYLYUXPWXJWAT5TSU7KDLANCNFSM4U3XRL2A).
|
Owner
|
@schwern are you still interested in implementing this? |
|
will give it a try someday |
Author
Sure. I'll have to reload it into my brain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike schema migrations, data migrations are easy to test but require a bit of special setup. This adds a spec file to the generator.
Closes #148