Conversation
BeritSchlueter
commented
Feb 28, 2025
BeritSchlueter
commented
- Adding DEGG PMT matching
- Changing typo in the in the scan functions
- Changing on line in OMSim Hit that stricter compiler can run the code
…writing one line in OMSimHitManager
There was a problem hiding this comment.
What was this change for again?
Did you check e.g. a single effective area direction if all other modules (especially DOM) still behave normally?
There was a problem hiding this comment.
I tested it with the mDOM and the D-Egg. The change was needed because else my compiler was complaining. I can test the DOM.,
There was a problem hiding this comment.
is the need/reason for the change of measurement file documented somewhere?
There was a problem hiding this comment.
I needed to change it for step 4, because else the beam started in the PMT glass.
There was a problem hiding this comment.
I know, I mean if that is written down (documented) anywhere - e.g. documentation/notebooks/detection_efficiency_matching or some other suitable place. Also add a backup of the original file (from the measurement) to that, else it will be lost over time.
There was a problem hiding this comment.
I uploaded the old file and it is written down in the commit of this file and also in the notebook.
There was a problem hiding this comment.
Looks reasonable to me. Please wait for this merge to go through first in case of conflicts.
There was a problem hiding this comment.
Previous merge is done which included the first batch of values you gave me. Since you did a few iterations they conflict at this point. Maybe to a quick side by side / plot comparison if some of those values drastically changed, but you already said that the effective area looks fine right?
There was a problem hiding this comment.
Sry for the late response. The notification email got in my spam folder. The effective area looks fine.
There was a problem hiding this comment.
@BeritSchlueter can you resolve the conflicts?
This file had to be revised because the laser beam of the simulated scan started in the PMT and not outside the PMT. New file is DEGG_used_z_compensation.txt
3 participants
