Run file-based test cases with each instance as DTSTART#923
Open
minichma wants to merge 2 commits intoical-org:version/6.0from
Open
Run file-based test cases with each instance as DTSTART#923minichma wants to merge 2 commits intoical-org:version/6.0from
minichma wants to merge 2 commits intoical-org:version/6.0from
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the file-based test cases to run each test case not only with the specified DTSTART but also with each of the expected recurrence instances as DTSTART as individual test case. This tests is helpful because in most test cases DTSTART is specified at the beginning of the respective interval. With this extension we also test for less common, yet valid patterns, i.e. DTSTART being specified not at the beginning of an interval.
The new test cases actually bring up some failing tests that should be fixed before this one can be merged.
The PR also contains some additional tests that cover similar cases where DTSTART is not at the beginning of an interval but run nicely.