Add integer compression/decompression.#2
Merged
samaloney merged 5 commits intoi4Ds:masterfrom Nov 13, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
============================================
+ Coverage 79.31% 100.00% +20.68%
============================================
Files 2 2
Lines 29 63 +34
============================================
+ Hits 23 63 +40
+ Misses 6 0 -6
Continue to review full report at Codecov.
|
samaloney
force-pushed
the
feat-int-compression
branch
6 times, most recently
from
2b7c823 to
f73bb92
Compare
samaloney
force-pushed
the
feat-int-compression
branch
from
f73bb92 to
aef0f49
Compare
* add tests for error raised * remove template code
nicHoch
reviewed
Nov 12, 2020
stixcore/calibration/compression.py
Outdated
| """ | ||
| values = np.atleast_1d(np.array(values)) | ||
| if not np.issubdtype(values.dtype, np.integer): | ||
| raise ValueError(f'Input must be an integer type not {values.dtype}') |
Collaborator
There was a problem hiding this comment.
we could create your own error types like: NonIntCompressionError
nicHoch
approved these changes
Nov 12, 2020
Collaborator
nicHoch
left a comment
nicHoch
left a comment
There was a problem hiding this comment.
we also discussed the usage of default parameters (s, k m ..).
but came to the conclusion that the codebase should have as less implicit states as possible
samaloney
force-pushed
the
feat-int-compression
branch
from
cbc5db2 to
5c80b21
Compare
nicHoch
pushed a commit
to nicHoch/STIXCore
that referenced
this pull request
Mar 1, 2021
Add integer compression/decompression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.