Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds backend detection for YouTube document URLs during LMS LTI launches and exposes a hypothesisClient.youtubeAssignment flag so the frontend can show the YouTube/GDPR banner when appropriate.
Changes:
- Add
_youtube_video_id_from_url()and a YouTube video ID regex (mirroring frontend patterns). - Set
hypothesisClient.youtubeAssignment = trueinJSConfig.add_document_url()when the URL is a YouTube video andYouTubeServiceis enabled. - Add unit tests covering flag set/unset scenarios and ensure
youtube_servicefixture is available in the js-config test module.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lms/resources/_js_config/__init__.py |
Adds YouTube URL detection and sets a client flag during JS config build. |
tests/unit/lms/resources/_js_config/__init___test.py |
Adds unit tests for the new youtubeAssignment client flag behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect YouTube assignments and set client flag for GDPR banner
When building the JS config, detect when the document URL is a YouTube video and the YouTube service is enabled, and set
hypothesisClient.youtubeAssignment = trueso the client can show the YouTube/GDPR banner for those assignments.Changes
_youtube_video_id_from_url()and a regex for YouTube URLs (youtube.com, youtu.be, embed, shorts, live, etc.), aligned with frontendutils/youtube.ts.add_document_url(), when the URL is a YouTube video and the YouTube service is enabled, sethypothesisClient.youtubeAssignment = true.via_urlfixture in two tests.