remove Yeoman and switched to Oclif for the CLI#640
Open
OsamaRab3 wants to merge 41 commits intohyperledger-labs:mainfrom
Open
remove Yeoman and switched to Oclif for the CLI#640OsamaRab3 wants to merge 41 commits intohyperledger-labs:mainfrom
OsamaRab3 wants to merge 41 commits intohyperledger-labs:mainfrom
Conversation
Contributor
Author
|
To run and test it locally, please follow these steps |
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
OsamaRab3
commented
Mar 1, 2026
package.json
Outdated
Comment on lines
+84
to
+86
| "bin": "ffablo", | ||
| "commands": "./generators/commands", | ||
| "dirname": "ffablo", |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| "bin": "ffablo", | |
| "commands": "./generators/commands", | |
| "dirname": "ffablo", | |
| "bin": "fablo", | |
| "commands": "./generators/commands", | |
| "dirname": "fablo", |
OsamaRab3
commented
Mar 1, 2026
src/app/index.ts
Outdated
Contributor
Author
There was a problem hiding this comment.
I believe we no longer need this file since we have migrated away from Yeoman. It does not seem to be used anywhere, so we can safely remove it.
OsamaRab3
commented
Mar 1, 2026
package.json
Outdated
Comment on lines
+25
to
+27
| "postpack": "shx rm -f oclif.manifest.json", | ||
| "posttest": "npm run lint", | ||
| "prepack": "oclif manifest && oclif readme", |
Contributor
Author
There was a problem hiding this comment.
Do we need these scripts?
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
dzikowski
reviewed
Mar 6, 2026
fablo.sh
Outdated
| } | ||
|
|
||
| executeOnFabloDocker() { | ||
| # set -x |
Contributor
There was a problem hiding this comment.
yes, we can remove that line
dzikowski
reviewed
Mar 6, 2026
fablo.sh
Outdated
Comment on lines
+202
to
+213
| if [ -f /etc/passwd ]; then | ||
| fablo_workspace_params+=( | ||
| -v /etc/passwd:/etc/passwd:ro | ||
| ) | ||
| fi | ||
|
|
||
| if [ -f /etc/group ]; then | ||
| fablo_workspace_params+=( | ||
| -v /etc/group:/etc/group:ro | ||
| ) | ||
| fi | ||
|
|
Contributor
There was a problem hiding this comment.
what does it do? do we need it?
dzikowski
reviewed
Mar 6, 2026
|
|
||
| if [ -f "$FABLO_TARGET/fabric-docker.sh" ]; then | ||
| echo "Executing Fablo Docker command: $1" | ||
| chmod +x "$FABLO_TARGET/fabric-docker.sh" || true |
Contributor
There was a problem hiding this comment.
that should not be required. We should grant x permission when the file is created
dzikowski
reviewed
Mar 6, 2026
dzikowski
reviewed
Mar 6, 2026
dzikowski
reviewed
Mar 6, 2026
dzikowski
reviewed
Mar 6, 2026
dzikowski
reviewed
Mar 6, 2026
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
…f they exist Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
…g and adjust output directories Signed-off-by: OsamaRab3 <osrab3@gmail.com>
…ted minimal files for security Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
Signed-off-by: OsamaRab3 <osrab3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the initial setup for removing and fully migrating the CLI to Oclif.
The goal is to simplify the CLI implementation, remove the generator dependency, and make future features easier to maintain and extend.
Current Progress
Implemented so far
Basic usage examples
Run the network:
Important Note
ffabloto avoid conflicts with the existingfablocommand during development.Once the migration is complete and fully tested, the name will be switched back to
fabloOnce the new Oclif implementation is fully completed and fully tested, I will remove all legacy code.