Implementation for share types user and group#205
Open
neurolabs wants to merge 2 commits intohobigo:masterfrom
Open
Implementation for share types user and group#205neurolabs wants to merge 2 commits intohobigo:masterfrom
neurolabs wants to merge 2 commits intohobigo:masterfrom
Conversation
added 2 commits
September 9, 2021 15:55
* url and token are only set when share type is publicLink * replaced optional memento members with |null ts types
Author
|
I managed to test this code by creating a UserGroup based share on a folder against a real nextcloud instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a base for implementing share types user and user group. fixes #204
Since I was not able to get a local development environment set up ( see #203 ), this is a first, untested approach.