Conversation
package.json
Outdated
| "version": "2.0.6", | ||
| "author": "Jeff Dickey @dickeyxxxx", | ||
| "dependencies": { | ||
|
|
There was a problem hiding this comment.
i ran fixpack package and committed the changes
There was a problem hiding this comment.
BTW, do we have any documentation for a checklist of things to do before submitting a PR? Like "run fixpack, use xyz formatter", etc.
There was a problem hiding this comment.
no, everything needing to be done is done with CI. Fixpack isn't crucial, I just wanted to get rid of the empty line mostly
src/commands/printbricks.js
Outdated
| DurationFlag | ||
| ] | ||
| run() { | ||
| let duration = new Duration(this) |
There was a problem hiding this comment.
you can put this above:
static flags = [
DurationFlag
]
duration = new Duration(this)
run() {…xample-plugin into feature/duration-mjo
|
good to merge when CI passes |
src/commands/dynorestart.js
Outdated
| } | ||
|
|
||
| main () { | ||
| return new Promise(resolve => { |
There was a problem hiding this comment.
a way you could make this cleaner is by creating a utility function wait:
const wait = msg => new Promise(resolve => setTimeout(resolve, ms))Then use it here like this:
await wait(5000)
console.log('Done restarting dynos')You could reuse it below as well.
c06a8dc to
3a25d18
Compare
|
CI checks keep failing. I do not think it is anything wrong with the code itself, rather I think it is running a test and does not pass the duration flag, and so that is causing the undefined error seen. @dickeyxxx may I have your input? |
6f0ba5b to
294ae55
Compare
294ae55 to
7e27a68
Compare
No description provided.