Add two more ways of authentication for the OAuth 1.0a workflow#47
Open
jsantos17 wants to merge 1 commit intohaskell:masterfrom
Open
Add two more ways of authentication for the OAuth 1.0a workflow#47jsantos17 wants to merge 1 commit intohaskell:masterfrom
jsantos17 wants to merge 1 commit intohaskell:masterfrom
Conversation
Collaborator
|
I applied #45, which has many conflicts with this PR. How would you like to proceed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a superset of #45. I'm not sure if the changes here make sense to add to Wreq. This adds three more authentication options:
This effectively makes Wreq capable of conducting the whole three-legged authentication required by a service provider such as Twitter.
Only OAuth 1.0a is supported, mainly because I'm not sure how to support OAuth 1.0 without adding three more constructors to the Auth type.