Skip to content

Enable React Compiler for SimulationTimeline chart components#8550

Draft
kube wants to merge 1 commit intomainfrom
cf/h-6324-compile-simulation-timeline
Draft

Enable React Compiler for SimulationTimeline chart components#8550
kube wants to merge 1 commit intomainfrom
cf/h-6324-compile-simulation-timeline

Conversation

@kube
Copy link
Collaborator

@kube kube commented Mar 15, 2026

Summary

  • Remove "use no memo" directives from CompartmentTimeSeries and StackedAreaChart
  • Replace manual useMemo/useCallback with plain functions, letting React Compiler handle memoization automatically
  • Net -55 lines from removing boilerplate memoization wrappers and dependency arrays

Test plan

  • Build passes (React Compiler compiles both components without errors)
  • All 272 unit tests pass
  • Lint passes (type-aware oxlint, 0 errors)
  • Manual: verify chart scrubbing, hover tooltips, and stacked area rendering in Storybook

🤖 Generated with Claude Code

Depends on #8539

@vercel
Copy link

vercel bot commented Mar 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment Mar 16, 2026 0:40am
petrinaut Error Error Mar 16, 2026 0:40am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
hashdotdesign Ignored Ignored Preview Mar 16, 2026 0:40am
hashdotdesign-tokens Ignored Ignored Preview Mar 16, 2026 0:40am

@github-actions github-actions bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team labels Mar 15, 2026
Copy link
Collaborator Author

kube commented Mar 15, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

Base automatically changed from cf/h-6324-migrate-petrinaut-to-oxlint-and-verify-react-compiler to main March 15, 2026 19:38
Remove "use no memo" directives and manual useMemo/useCallback from
CompartmentTimeSeries and StackedAreaChart. The React Compiler handles
memoization automatically for these components.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

1 participant