FE-502: Improve SDCPN file import/export with Zod validation and layout fix by kube · Pull Request #8536 · hashintel/hash

kube · 2026-03-12T23:14:17Z

🌟 What is the purpose of this PR?

Fixes the bug where importing an SDCPN file exported without visual info breaks the editor. Also improves the file format with Zod validation and a versioned envelope.

🔗 Related links

FE-502: Importing back an export without visual info breaks the editor (internal)

🔍 What does this change?

Moves file format code into src/file-format/ (export-sdcpn, import-sdcpn, remove-visual-info, old-formats/)
Replaces manual type guards with Zod schemas for import validation, matching the pattern used for clipboard in clipboard/types.ts
Adds versioned file format envelope (version, meta.generator) to exported files
Fixes layout on import: when nodes are missing x/y, runs ELK layout before calling createNewNet (avoids a stale closure bug where positions were applied to the wrong net)
Adds onlyMissingPositions option to calculateGraphLayout for partial re-layout of imported nodes
Adds ImportErrorDialog showing Zod validation errors with a "Create empty net" fallback

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

do not affect the execution graph

❓ How to test this?

Export a net as "JSON without visual info"
Import the exported file back
Confirm all nodes are laid out by ELK (not stacked at origin)
Import a malformed JSON file and confirm the error dialog appears

vercel · 2026-03-12T23:14:22Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hash	Ready	Preview, Comment	Mar 15, 2026 0:24am
petrinaut	Ready	Preview	Mar 15, 2026 0:24am

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
hashdotdesign	Ignored	Preview	Mar 15, 2026 0:24am
hashdotdesign-tokens	Ignored	Preview	Mar 15, 2026 0:24am

kube · 2026-03-12T23:14:32Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

FE-502: Improve SDCPN file import/export with Zod validation and layout fix #8536 👈 (View in Graphite)
FE-504: Add Copy, Paste and Select All to Petrinaut editor #8533
FE-512: Create FilterableListSubView with keyboard navigation and search #8532
H-6324: Migrate petrinaut to oxlint and verify React Compiler #8539 : 4 other dependent PRs (#8537 , #8541 , #8549 and 1 other)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

cursor · 2026-03-12T23:15:55Z

PR Summary

Medium Risk
Changes the on-disk SDCPN JSON format (adds version/meta) and rewrites import parsing/layout behavior, which could affect backward/forward compatibility and editor load behavior. Risk is mitigated by explicit legacy/old-format support and schema-based validation, but import paths and layout generation are still user-facing and failure-prone.

Overview
Adds a versioned SDCPN JSON file envelope (version, meta.generator) to exports and introduces Zod-based schemas (sdcpnFileSchema, legacySdcpnFileSchema, plus a pre-2025-11-28 schema) to validate and parse imported files.

Reworks import to return structured results with errors, explicitly reject unknown versions, and auto-fill missing visual fields (defaulting missing x/y, iconSlug, displayColor). When imported nets have missing positions, the editor now runs ELK layout before createNewNet, using a new calculateGraphLayout({ onlyMissingPositions: true }) option to only reposition nodes at (0,0).

Updates the editor UI to show an ImportErrorDialog on failure (with a “Create empty net” fallback), removes the old callback/alert-based importer, and relocates old-format conversion exports under file-format/.

^{Written by Cursor Bugbot for commit c721144. This will update automatically on new commits. Configure here.}

libs/@hashintel/petrinaut/src/views/Editor/editor-view.tsx

libs/@hashintel/petrinaut/src/file-format/import-sdcpn.ts

augmentcode · 2026-03-12T23:29:56Z

🤖 Augment PR Summary

Summary: This PR refactors Petrinaut’s SDCPN JSON import/export to be versioned and Zod-validated, and improves the import experience when node positions are missing.

Changes:

Moved SDCPN file I/O helpers into src/file-format/ (export, import, remove-visual-info, old-format converters).
Introduced a v1 on-disk JSON envelope with version and meta.generator metadata on export.
Added Zod schemas for both the versioned format and a legacy (unversioned) format, using defaults for optional sections.
Reworked import to return a structured result (success/error) and to detect missing x/y coordinates.
On import, fills missing coordinates and (when needed) runs ELK layout before calling createNewNet to avoid stale-closure issues.
Extended calculateGraphLayout with an onlyMissingPositions option to support partial re-layout.
Added an ImportErrorDialog to display validation/read errors with a “Create empty net” fallback.

Technical Notes: The new importer prefers the versioned schema first, falls back to the legacy schema, and uses user settings (compact vs classic node dimensions) when computing ELK layout.

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.

augmentcode · 2026-03-12T23:29:57Z

libs/@hashintel/petrinaut/src/lib/calculate-graph-layout.ts

+  const needsPosition = new Set<string>();
+  if (options?.onlyMissingPositions) {
+    for (const place of sdcpn.places) {
+      if (place.x === 0 && place.y === 0) {


In onlyMissingPositions mode, a node is treated as “missing” only when both x and y are 0, but the import path can produce partially-missing coordinates (e.g. x filled to 0 while y was present), which would then never get a new position. This can leave imported nodes stuck at a 0 coordinate even though hadMissingPositions triggered layout.

Severity: medium

Other Locations

libs/@hashintel/petrinaut/src/file-format/import-sdcpn.ts:38

libs/@hashintel/petrinaut/src/views/Editor/editor-view.tsx:147

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

augmentcode · 2026-03-12T23:29:57Z

libs/@hashintel/petrinaut/src/file-format/import-sdcpn.ts

+  }
+
+  // Fall back to legacy format
+  const legacy = legacySdcpnFileSchema.safeParse(data);


parseSDCPNFile currently requires the file to match the current SDCPN shape (colorId, differentialEquationId, etc.) before convertOldFormatToSDCPN runs, so pre-2025-11-28 exports (which use fields like place.type) will fail validation and never be migrated. If the goal is to keep old-file import working, this validation step may be too strict for legacy inputs.

Severity: medium

Other Locations

libs/@hashintel/petrinaut/src/file-format/types.ts:10

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

augmentcode · 2026-03-12T23:29:57Z

libs/@hashintel/petrinaut/src/file-format/types.ts

+/**
+ * Schema for the legacy file format (no version/meta, just title + SDCPN data).
+ */
+export const legacySdcpnFileSchema = sdcpnSchema.extend({


legacySdcpnFileSchema is non-strict, so a file that includes version/meta but fails sdcpnFileSchema (e.g., version > supported) can still be accepted as “legacy” after those keys are stripped. That could silently import future/incompatible versioned files instead of surfacing an error.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

libs/@hashintel/petrinaut/src/file-format/types.ts

augmentcode

Review completed. 4 suggestions posted.

Comment augment review to trigger a new review at any time.

augmentcode · 2026-03-14T20:01:12Z

libs/@hashintel/petrinaut/src/lib/calculate-graph-layout.ts

- * @returns A promise that resolves to an array of node positions
+ * @param dims - Node dimensions for places and transitions
+ * @param options.onlyMissingPositions - When true, only nodes with x=0 and y=0 will receive new positions.
+ *   Nodes that already have non-zero positions are included in the layout graph (so ELK can route around them)


The docstring says existing non-zero nodes are included “so ELK can route around them,” but elkNodes never passes existing x/y (or any fixed-position hint) into the ELK graph. In onlyMissingPositions mode this can yield returned positions that don’t account for the unchanged nodes, potentially causing overlaps when only the “missing” nodes get applied.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

augmentcode · 2026-03-14T20:01:12Z

libs/@hashintel/petrinaut/src/lib/calculate-graph-layout.ts

+  const needsPosition = new Set<string>();
+  if (options?.onlyMissingPositions) {
+    for (const place of sdcpn.places) {
+      if (place.x === 0 && place.y === 0) {


In onlyMissingPositions mode, treating (0,0) as “missing” can also catch nodes that were intentionally positioned at the origin (if some other node had missing coords and triggered relayout). That could unexpectedly move a legitimately-placed node.

Severity: low

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

augmentcode · 2026-03-14T20:01:12Z

libs/@hashintel/petrinaut/src/views/Editor/editor-view.tsx

  useSelectionCleanup();

-  function handleNew() {
+  const handleCreateEmpty = useCallback(() => {


useCallback is used for handleCreateEmpty, but Petrinaut’s React Compiler guidance (CLAUDE.md) asks to avoid manual memoization unless there’s a specific incompatibility. If there isn’t a concrete need for stable identity here, this is extra complexity and may be worth reconsidering.

Severity: low

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

augmentcode · 2026-03-14T20:01:12Z

libs/@hashintel/petrinaut/src/file-format/import-sdcpn.ts

+/**
+ * Parses raw JSON data into an SDCPN, handling both versioned and legacy formats.
+ */
+export const parseSDCPNFile = (data: unknown): ImportResult => {


parseSDCPNFile is a key new parsing/validation surface, but I don’t see unit coverage for versioned vs legacy inputs or malformed JSON cases. Adding a small set of tests here would help lock in backward-compat and error-reporting behavior.

Severity: low

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

libs/@hashintel/petrinaut/src/file-format/types.ts

- Move file format code into `src/file-format/` (export, import, remove-visual-info, old-formats) - Replace manual type guards with Zod schemas for import validation, matching clipboard types pattern - Add versioned file format envelope (version, meta.generator) to exports - Fix stale closure bug: run ELK layout before createNewNet so positions are baked into the data - Add `onlyMissingPositions` option to calculateGraphLayout for partial re-layout - Add ImportErrorDialog showing Zod validation errors with "Create empty net" fallback Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

The Zod schema required iconSlug and displayColor on color types, but these fields are stripped by "export without visual info". Make them optional in the schema and fill defaults on import, matching how missing x/y positions are already handled. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Move old format Zod schema into old-formats/pre-2025-11-28/ - Integrate old format parsing into parseSDCPNFile so pre-2025-11-28 files are validated and converted during import (previously dead code) - Reject versioned files from legacy fallback path to prevent silently accepting unsupported future versions - Remove dead convertOldFormatToSDCPN call from editor-view - Remove unnecessary useCallback (React Compiler handles memoization) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Move the unsupported-version rejection from a Zod .refine() (which never worked because z.object() strips unknown keys first) into parseSDCPNFile where we can inspect the raw data. Remove unused SDCPNFileFormat type export. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

cursor · 2026-03-15T00:30:59Z

libs/@hashintel/petrinaut/src/file-format/export-sdcpn.ts

+    },
+    title,
+    ...sdcpnToExport,
+  };


Export spread order lets stale title overwrite current title

High Severity

The import produces SDCPNWithTitle objects where title is included in the SDCPN data. This title is passed as petriNetDefinition to createNewNet, persisting it in the stored net object. In exportSDCPN, ...sdcpnToExport is spread after the explicit title parameter, so the stale import-time title on petriNetDefinition overwrites the user's current title. If a user imports a file, renames the net, and exports, the exported file will contain the original import title instead of the renamed one.

Additional Locations (2)

libs/@hashintel/petrinaut/src/file-format/import-sdcpn.ts#L45-L64

libs/@hashintel/petrinaut/src/views/Editor/editor-view.tsx#L169-L173

cursor · 2026-03-15T00:30:59Z

libs/@hashintel/petrinaut/src/lib/calculate-graph-layout.ts

+      return {};
+    }
+  }
+


ELK layout ignores existing node positions for partial relayout

Low Severity

When onlyMissingPositions is set, the JSDoc states that nodes with existing positions are "included in the layout graph so ELK can route around them." However, the ELK nodes are built without x/y coordinates, so ELK has no knowledge of existing positions and lays out all nodes from scratch. For partial relayout scenarios (some nodes positioned, some not), ELK-assigned positions for missing nodes may overlap with existing ones. This doesn't affect the current import use case where all positions are missing.

github-actions bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team labels Mar 12, 2026

kube mentioned this pull request Mar 12, 2026

FE-504: Add Copy, Paste and Select All to Petrinaut editor #8533

Open

3 tasks

kube marked this pull request as ready for review March 12, 2026 23:15

graphite-app bot assigned kube Mar 12, 2026

vercel bot deployed to Preview – petrinaut March 12, 2026 23:17 View deployment

cursor bot reviewed Mar 12, 2026

View reviewed changes

libs/@hashintel/petrinaut/src/views/Editor/editor-view.tsx Outdated Show resolved Hide resolved

libs/@hashintel/petrinaut/src/file-format/import-sdcpn.ts Show resolved Hide resolved

vercel bot deployed to Preview – hash March 12, 2026 23:21 View deployment

augmentcode bot reviewed Mar 12, 2026

View reviewed changes

kube changed the title ~~Improve SDCPN file import/export with Zod validation and layout fix~~ FE-502: Improve SDCPN file import/export with Zod validation and layout fix Mar 13, 2026

kube changed the base branch from cf/petrinaut-copy-paste to graphite-base/8536 March 14, 2026 19:32

kube mentioned this pull request Mar 14, 2026

FE-512: Create FilterableListSubView with keyboard navigation and search #8532

Open

3 tasks

kube force-pushed the cf/petrinaut-better-export-import branch from 82c0b1c to 5cb778f Compare March 14, 2026 19:48

kube force-pushed the graphite-base/8536 branch from 7889b18 to 1a404fc Compare March 14, 2026 19:48

kube changed the base branch from graphite-base/8536 to cf/petrinaut-copy-paste March 14, 2026 19:48

vercel bot deployed to Preview – petrinaut March 14, 2026 19:51 View deployment

cursor bot reviewed Mar 14, 2026

View reviewed changes

libs/@hashintel/petrinaut/src/file-format/types.ts Show resolved Hide resolved

vercel bot deployed to Preview – hash March 14, 2026 19:57 View deployment

kube marked this pull request as draft March 14, 2026 19:57

kube marked this pull request as ready for review March 14, 2026 19:57

kube force-pushed the cf/petrinaut-better-export-import branch from 5cb778f to 9d9196d Compare March 14, 2026 20:01

augmentcode bot reviewed Mar 14, 2026

View reviewed changes

vercel bot deployed to Preview – petrinaut March 14, 2026 20:04 View deployment

kube requested a review from CiaranMn March 14, 2026 20:05

vercel bot deployed to Preview – hash March 14, 2026 20:07 View deployment

graphite-app bot requested a review from a team March 14, 2026 20:21

vercel bot deployed to Preview – petrinaut March 14, 2026 20:30 View deployment

vercel bot deployed to Preview – hash March 14, 2026 20:34 View deployment

cursor bot reviewed Mar 14, 2026

View reviewed changes

libs/@hashintel/petrinaut/src/file-format/types.ts Outdated Show resolved Hide resolved

libs/@hashintel/petrinaut/src/file-format/types.ts Outdated Show resolved Hide resolved

kube and others added 4 commits March 15, 2026 01:17

kube force-pushed the cf/petrinaut-better-export-import branch from e6b7192 to c721144 Compare March 15, 2026 00:17

kube force-pushed the cf/petrinaut-copy-paste branch from 4353358 to 927d425 Compare March 15, 2026 00:17

vercel bot deployed to Preview – petrinaut March 15, 2026 00:21 View deployment

vercel bot deployed to Preview – hash March 15, 2026 00:24 View deployment

cursor bot reviewed Mar 15, 2026

View reviewed changes

Conversation

kube commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌟 What is the purpose of this PR?

🔗 Related links

🔍 What does this change?

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

📜 Does this require a change to the docs?

🕸️ Does this require a change to the Turbo Graph?

❓ How to test this?

Uh oh!

vercel bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kube commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

Uh oh!

augmentcode bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

augmentcode bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

augmentcode bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

augmentcode bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

augmentcode bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

augmentcode bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

augmentcode bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

augmentcode bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Mar 15, 2026

Choose a reason for hiding this comment

Export spread order lets stale title overwrite current title

Uh oh!

cursor bot Mar 15, 2026

Choose a reason for hiding this comment

ELK layout ignores existing node positions for partial relayout

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

1 participant

kube commented Mar 12, 2026 •

edited

Loading

vercel bot commented Mar 12, 2026 •

edited

Loading

kube commented Mar 12, 2026 •

edited

Loading

cursor bot commented Mar 12, 2026 •

edited

Loading

augmentcode bot commented Mar 12, 2026 •

edited

Loading