Replace explicit serde-json-wasm dependency with cw_std::to_json_string#486
Merged
Replace explicit serde-json-wasm dependency with cw_std::to_json_string#486
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
=======================================
Coverage 71.89% 71.89%
=======================================
Files 63 63
Lines 3882 3882
=======================================
Hits 2791 2791
Misses 1091 1091 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e6828c8 to
bf19abd
Compare
jawoznia
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with CosmWasm 3, no serde-json-wasm dependency will be used anymore. So for the sake of maintainability, we can just use cw_std::to_json_string which uses whatever encoder cosmwasm_std comes with.
This PR is potentially breaking because the
pub use serde_json_wasm as serde_jsonis removed. But I guess this is only needed for the macro stuff, right?