Resolve SW-13543 "Update the first line of asc file to use logging start time instead of asc file created time"#1903
Open
AmanKAggarwal wants to merge 1 commit intohardbyte:mainfrom
Conversation
AmanKAggarwal
force-pushed
the
SW-13543-update-asc-file-start-time
branch
from
4ba1914 to
a960a51
Compare
zariiii9003
reviewed
Feb 15, 2025
| # This is guaranteed to not be None since we raise ValueError in __init__ | ||
| if not self.file.closed: | ||
| self.file.write("End TriggerBlock\n") | ||
| if self.started is not None: |
Collaborator
There was a problem hiding this comment.
Why do you check for None?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is because we create the asc file when the user requests to export their log file into asc format. Using the file created time means when they open the generated ASC file in CANoe, CANoe identifies that created time as the session start time for data which is incorrect