implement TRCWriter feature for v1.1 #1702
Open
hiteshhedwig wants to merge 4 commits intohardbyte:mainfrom
Open
implement TRCWriter feature for v1.1 #1702hiteshhedwig wants to merge 4 commits intohardbyte:mainfrom
hiteshhedwig wants to merge 4 commits intohardbyte:mainfrom
Conversation
3a85f35 to
e60393f
Compare
Collaborator
|
@hiteshhedwig I rebased and fixed the mypy issues. You should include the new parameter in the docstring and add some test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current
TRCWriterdoes not implement method for fileversion 1.1. So i have implemented it. And trc can be generated as followsPlease feel free to leave any feedback