Conversation
Implement AppBar, AppBarItem, AppBarBackButton, AppBarTitle, and AppBarAvatar components using semantic design tokens. Includes Ladle stories for all three Figma variants plus long title truncation. Closes #56 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
フロントエンドの画面上部ナビゲーションとして利用する AppBar 系コンポーネント群を追加し、Ladle で Figma 想定バリエーションの見た目確認ができるようにする PR です。
Changes:
AppBar/AppBarItem/AppBarBackButton/AppBarTitle/AppBarAvatarの UI コンポーネントを追加- 主要 4 パターン(アバター + タイトル、戻る + タイトル、戻る + タイトル + アクション、長文タイトルの truncate)の Ladle ストーリーを追加
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| packages/frontend/app/components/ui/app-bar.tsx | AppBar コンポーネント群の実装を追加 |
| packages/frontend/app/components/app-bar.stories.tsx | AppBar の Ladle ストーリーを追加 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
- Replace external dicebear URL with inline data URI for avatar - Replace window.history.back() with console.log in Ladle stories - Remove typography classes from AppBarItem center slot (keep in AppBarTitle) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
関連 Issue
Closes #56
変更内容
AppBar(sticky コンテナ)、AppBarItem(left/center/right スロット)、AppBarBackButton、AppBarTitle、AppBarAvatarの5コンポーネントを実装動作確認
設計メモ
absolute配置、中央はpx-40で重なり防止 +truncatearia-label、focus-visible:ring対応🤖 Generated with Claude Code