Time to switch to jakarta namespace#16
Time to switch to jakarta namespace#16ManfredTremmel wants to merge 6 commits intogwtplus:masterfrom
Conversation
- guice updated from 4.2.3 to 7.0.0 - gwt updated from 2.9.0 to 2.12.1 - all other dependencies updated to latest versions - java minimum requirement now is 11
|
Hi, thank you for the PR. I'll setup GitHub actions before merge so we can monitor build status before merging. |
|
If you need something for testing, I've updated some projects:
|
|
Hi @metteo |
|
Please rebase on master to pull github action. |
|
Verify checked failed because of some issue with dependency graph even though it worked when merging the action to master. I'm wondering what's up with the exceptions during test execution. Do you get them locally too? |
|
I had no problems with local builds, but I don't upload any dependency graph. |
|
On https://oss.sonatype.org/content/repositories/snapshots/de/knightsoft-net/gin/4.0.0-SNAPSHOT/ you can find my last snapshot build in my own groupId. I've build it by simply |
|
I think this problem is the same as in Github Action Failing When Merging Forks #14, last comment has a possible solution. I'll change the github action in my branch, let's show if it helps. |
|
Is there any update on this as it would be great to get @ManfredTremmel's work get integrated into gin and therefore also in gwtp. |
|
I've released a version using my groupId: de.knightsoft-net:gin:4.0.0, so feel free to use it until the changes are merged. Also the gwtp stuff was forked, because I've got no response. |
switched from javax.inject to jakarta.inject namespace