fix: check modules before adding base meta modules#249
Open
meteyou wants to merge 1 commit intoguysoft:develfrom
Open
fix: check modules before adding base meta modules#249meteyou wants to merge 1 commit intoguysoft:develfrom
meteyou wants to merge 1 commit intoguysoft:develfrom
Conversation
Owner
|
Why are you doing this?
|
Contributor
Author
|
i just had issues to build images, because i got the error message, that the module was not found. just my 2 cents: i don't like a system, which just adds modules and I don't know it... I would prefer to add modules myself, instead "auto hidden added modules". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just add a condition before adding base meta modules. It just checks if the module exists, before adding it.