Css family name truncated to single word without spaces#34
Open
kontur wants to merge 2 commits intographicore:masterfrom
Open
Css family name truncated to single word without spaces#34kontur wants to merge 2 commits intographicore:masterfrom
kontur wants to merge 2 commits intographicore:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that under certain circumstances a css family name with several spaces (and possibly because of keywords like Regular in that extensive family name) in the name would fail to render. Truncating such a long family name that includes spaces into a single word solves this problem with the only "drawback" being that the display css font-family will be truncated, i.e. instead of
font-family: Very long name font regular;it would show asfont-family: Verylongnamefontregular;in the browser inspector.I expanded the current
_getCSSFamilyNamepass through to perform this modification.