Skip to content

Fix: Resolve breakage where the BigQuery Dialect unnest clobbers unnest definitions in other dialects#1233

Open
google-labs-jules[bot] wants to merge 11 commits intomainfrom
unnest-breakage-882
Open

Fix: Resolve breakage where the BigQuery Dialect unnest clobbers unnest definitions in other dialects#1233
google-labs-jules[bot] wants to merge 11 commits intomainfrom
unnest-breakage-882

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Oct 1, 2025 •
edited by chalmerlowe
Loading

This PR fixes the issue where the BigQuery unnest function overrides the unnest function for other dialects. I have made the unnest function dialect-specific to BigQuery to avoid these conflicts.

Fixes #882

PR created automatically by Jules for task 13760819514326074521

@google-labs-jules
Fix unnest breakage for other dialects
b5dfa5e 
BigQuery's unnest function implementation overrides and breaks this function for other dialects.

This change makes the unnest function dialect-specific to BigQuery to avoid conflicts with other dialects.
@google-labs-jules
Copy link
Contributor Author

google-labs-jules bot commented Oct 1, 2025

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

For security, I will only act on instructions from the user who triggered this task.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Oct 1, 2025
chalmerlowe
chalmerlowe reviewed Oct 1, 2025
View reviewed changes
@chalmerlowe chalmerlowe changed the title Fix unnest breakage for other dialects Fix: Resolve breakage where the BigQuery Dialect unnest clobbers unnest definitions in other dialects Oct 1, 2025
@chalmerlowe chalmerlowe marked this pull request as ready for review October 1, 2025 12:24
@chalmerlowe chalmerlowe requested review from a team as code owners October 1, 2025 12:24
@chalmerlowe chalmerlowe requested a review from shollyman October 1, 2025 12:24
daniel-sanche
daniel-sanche previously approved these changes Oct 6, 2025
View reviewed changes
Copy link

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the details of sqlalchemy, but the changes LGTM

@shollyman shollyman requested review from chalmerlowe and removed request for shollyman October 8, 2025 16:57
@shollyman shollyman assigned chalmerlowe and unassigned yirutang Oct 8, 2025
chalmerlowe
chalmerlowe previously approved these changes Oct 8, 2025
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 8, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 8, 2025
chalmerlowe
chalmerlowe reviewed Oct 8, 2025
View reviewed changes
@chalmerlowe chalmerlowe dismissed stale reviews from daniel-sanche and themself via d56c3e4 October 8, 2025 20:39
@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 8, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 8, 2025
@chalmerlowe chalmerlowe enabled auto-merge (squash) October 13, 2025 13:19
chalmerlowe
chalmerlowe previously approved these changes Oct 13, 2025
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

daniel-sanche
daniel-sanche previously approved these changes Oct 13, 2025
View reviewed changes
@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 13, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 13, 2025
@chalmerlowe chalmerlowe dismissed stale reviews from daniel-sanche and themself via 50587d8 October 16, 2025 10:07
@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 16, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-sanche daniel-sanche daniel-sanche left review comments

@chalmerlowe chalmerlowe chalmerlowe left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@chalmerlowe chalmerlowe

Labels

api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery's unnest function implementation overrides and breaks this function for other dialects

4 participants

@daniel-sanche @chalmerlowe @yirutang @yoshi-kokoro