feat(jdbc): enable gRPC Keep-Alive for Storage Read API

[keshavdandeva]

b/473628902

Enabled gRPC Keep-Alive settings for BigQuery Storage Read API connections in the JDBC driver.

Changes

• BigQueryConnection.java: Configured the TransportChannelProvider with:
  • KeepAliveTime: 10 seconds
  • KeepAliveTimeout: 5 seconds
  • KeepAliveWithoutCalls: true
• BigQueryConnectionTest.java: Added testBigQueryReadClientKeepAliveSettings

[gemini-code-assist]

Summary of Changes

Hello @keshavdandeva, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Google Cloud BigQuery JDBC driver by integrating gRPC Keep-Alive functionality for its Storage Read API connections. This change aims to maintain more stable and persistent connections, preventing premature disconnections and improving the reliability of data retrieval operations by ensuring the underlying gRPC channel remains active.

Highlights

• gRPC Keep-Alive Configuration: Enabled gRPC Keep-Alive settings for BigQuery Storage Read API connections within the JDBC driver. Specifically, KeepAliveTime is set to 10 seconds, KeepAliveTimeout to 5 seconds, and KeepAliveWithoutCalls to true.
• New Test Case: Added testBigQueryReadClientKeepAliveSettings to BigQueryConnectionTest.java to verify the correct application of the gRPC Keep-Alive settings to the TransportChannelProvider.

Changelog

• google-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryConnection.java
  • Imported InstantiatingGrpcChannelProvider.
  • Modified the getBigQueryReadClientConnection method to conditionally apply gRPC Keep-Alive settings (KeepAliveTime, KeepAliveTimeout, KeepAliveWithoutCalls) to the TransportChannelProvider if it is an instance of InstantiatingGrpcChannelProvider.
• google-cloud-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryConnectionTest.java
  • Added necessary imports for InstantiatingGrpcChannelProvider, TransportChannelProvider, BigQueryReadClient, and Duration.
  • Introduced a new test method, testBigQueryReadClientKeepAliveSettings, to assert that the BigQueryReadClient's TransportChannelProvider is correctly configured with the specified Keep-Alive settings.

Activity

• The pull request was opened by keshavdandeva.
• Initial commit introduced the feature to enable gRPC Keep-Alive for the Storage Read API and added a corresponding test.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully introduces gRPC Keep-Alive settings for BigQuery Storage Read API connections, which is a beneficial enhancement for connection stability. The changes correctly integrate the InstantiatingGrpcChannelProvider to apply these settings, and a new test case has been added to verify their application. The implementation is straightforward and directly addresses the stated objective.

[gemini-code-assist]

The Keep-Alive settings (time, timeout, and withoutCalls) are currently hardcoded. While these are reasonable defaults, making them configurable via connection properties would provide greater flexibility for users to fine-tune behavior based on their specific network environments or use cases. This would align with how other connection parameters are handled.