fix(AIP-191): skip java_multiple_files for edition >= 2024

[noahdietz]

java_multiple_files option was removed in Protobuf Edition 2024. Only execute this rule if the descriptor uses an syntax/edition value earlier than edition 2024.

Note: proto2/proto3 syntax are captured in the Edition enum as "smaller" values allowing us to do a simple "less than edition 2024" check.

Addresses internal bug report http://b/485818131

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the java_multiple_files linter rule to align with changes introduced in Protobuf Edition 2024. By making the rule conditional, it prevents unnecessary linting errors for newer Protobuf definitions, ensuring the linter remains compatible and relevant across different Protobuf editions.

Highlights

• Conditional Rule Application: The java_multiple_files linter rule (AIP-191) will now only be applied to Protobuf files using editions earlier than Edition 2024, as the java_multiple_files option was removed in Protobuf Edition 2024.
• New Test Case: A new test has been added to specifically verify that the java_multiple_files rule correctly skips files configured with Protobuf Edition 2024.

Changelog

• rules/aip0191/java_multiple_files.go
  • Imported protodesc and descriptorpb packages.
  • Modified the OnlyIf condition to check if the Protobuf file's edition is less than EDITION_2024.
• rules/aip0191/java_multiple_files_test.go
  • Imported proto, protodesc, and descriptorpb packages.
  • Added TestJavaMultipleFiles_SkipEditionsBeyond2024 to test the new edition-based skipping logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the java_multiple_files rule to skip files using Protobuf editions 2024 or newer. My review identified a duplicate import in java_multiple_files.go that will cause a compilation failure, and an issue where the new test case in java_multiple_files_test.go doesn't properly test the new edition-checking logic due to a missing package in the test setup. My review includes suggestions to fix these issues.