Handle empty crash signatures and descriptions in crash deduplication. #1981
+84
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds checks for empty crash signatures and descriptions. By default, inputs with empty metadata are now ignored with an error log. An environment variable, FUZZTEST_FAIL_ON_EMPTY_CRASH_METADATA, can be set to make these empty metadata cases fatal. Additionally, failures to read crash descriptions now cause the corresponding input to be ignored. PiperOrigin-RevId: 868929414
copybara-service
bot
force-pushed
the
cl/868293233
branch
from
ff280d6 to
98b0970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle empty crash signatures and descriptions in crash deduplication.
This change adds checks for empty crash signatures and descriptions. By default, inputs with empty metadata are now ignored with an error log. An environment variable, FUZZTEST_FAIL_ON_EMPTY_CRASH_METADATA, can be set to make these empty metadata cases fatal. Additionally, failures to read crash descriptions now cause the corresponding input to be ignored.