string_view.rs: improve the documentation on raw_string_view.#633
Closed
copybara-service[bot] wants to merge 0 commit intomainfrom
Closed
string_view.rs: improve the documentation on raw_string_view.#633copybara-service[bot] wants to merge 0 commit intomainfrom
string_view.rs: improve the documentation on raw_string_view.#633copybara-service[bot] wants to merge 0 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_879318511
branch
2 times, most recently
from
5cf74f5 to
d1a1d44
Compare
copybara-service
bot
changed the title
raw_string_view.string_view.rs: improve the documentation on raw_string_view.
copybara-service
bot
force-pushed
the
test_879318511
branch
from
d1a1d44 to
c1eec52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
string_view.rs: improve the documentation onraw_string_view.Give some context on what it even is, and make it clearer what the rules are
about lifetimes. Precisely define the rules in one place, and refer to that one
place everywhere else, rather than partially and inconsistently repeating the
rules in each other place. Clarify that the (IMO) too-fancy lifetime API on
as_liveis not actually a protection against anything.