Make the template for string_view instantiate as raw_string_view.#629
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Make the template for string_view instantiate as raw_string_view.#629copybara-service[bot] wants to merge 1 commit intomainfrom
raw_string_view.#629copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
This doesn't solve preferred_name in general: 1. std::string needs work because we can't hardcode the build-specific `__u` in string_wrapper. So first need to strip the inline namespace when stringifying the type names for the standard library. 2. std::pmr::string doesn't work, and I don't know why. It looks as if when we look at the template specialization, it's fully concrete, but when we look at the type alias, it doesn't point at a complete type. That doesn't make sense to me. So, something is wrong, but idk what. Still, I believe this is approximately the right approach and will generalize to all of these types with time. Disclosure: some AI was used at the start and at one point during the middle but man it choked hard, and I believe everything here is hand-written (but can't be 100% sure). PiperOrigin-RevId: 878107358
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the template for string_view instantiate as
raw_string_view.This doesn't solve preferred_name in general:
__uin string_wrapper. So first need to strip the inline namespace when stringifying the type names for the standard library.Still, I believe this is approximately the right approach and will generalize to all of these types with time.
Disclosure: some AI was used at the start and at one point during the middle but man it choked hard, and I believe everything here is hand-written (but can't be 100% sure).