Make CRUBIT_INTERNAL_RUST_TYPE accept trailing type arguments.#569
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Make CRUBIT_INTERNAL_RUST_TYPE accept trailing type arguments.#569copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Example:
```cpp
CRUBIT_INTERNAL_RUST_TYPE("Foo", T)
```
Right now, this just replaces the default behavior of `ExistingRustType.template_args`, which used to just be a list with 1:1 correspondence with the order of the template args on the type. After this change, that list now corresponds to the types that are put in the list. A concrete example of this change is that `rs_std::SliceRef` now uses the new annotation syntax:
```cpp
// old
CRUBIT_INTERNAL_RUST_TYPE("&[]")
// new
CRUBIT_INTERNAL_RUST_TYPE("&[]", T)
```
This also begins (but does not complete) supporting const generics. By writing `crubit::const_generic<N>` instead of a type like so:
```cpp
CRUBIT_INTERNAL_RUST_TYPE("Foo", crubit::const_generic<123>)
```
It will go into the `template_args` list as a `TemplateArg::Int` instead of a `TemplateArg::Type`. Boolean literals are also supported.
PiperOrigin-RevId: 876372938
copybara-service
bot
force-pushed
the
test_876372938
branch
from
c5f502c to
024a686
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make CRUBIT_INTERNAL_RUST_TYPE accept trailing type arguments.
Example:
Right now, this just replaces the default behavior of
ExistingRustType.template_args, which used to just be a list with 1:1 correspondence with the order of the template args on the type. After this change, that list now corresponds to the types that are put in the list. A concrete example of this change is thatrs_std::SliceRefnow uses the new annotation syntax:This also begins (but does not complete) supporting const generics. By writing
crubit::const_generic<N>instead of a type like so:It will go into the
template_argslist as aTemplateArg::Intinstead of aTemplateArg::Type. Boolean literals are also supported.